| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Kevin Grittner <kevin(dot)grittner(at)wicourts(dot)gov>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SSI error messages |
| Date: | 2011-07-27 20:27:55 |
| Message-ID: | 1311798342-sup-2237@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Excerpts from Peter Eisentraut's message of mié jul 27 16:19:22 -0400 2011:
> On lör, 2011-07-16 at 15:01 -0400, Tom Lane wrote:
> > Well, as I mentioned in the commit message, I've thought for some time
> > that there were use cases for errdetail_internal. Whether these
> > particular places in predicate.c use it or not doesn't affect that.
>
> Looking at commit 1af37ec96d97722aeb527f5f43d6f6f2304f0861, not all of
> these are strings that don't need to be translated. For example, you
> can't assume that the translation of "%s: %s" is "%s: %s" or that the
> translation of "%s (%x)" is "%s (%x)". I'll review those in detail when
> I find some time, but some of them will probably have to be reverted.
Hmm, if "%s: %s" has different uses in different places, we're going to
need a more involved solution because they might not translate
identically.
In any case, we need /* translator: */ comments to explain what's going
on.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2011-07-27 21:08:48 | Re: XMLATTRIBUTES vs. values of type XML |
| Previous Message | Peter Eisentraut | 2011-07-27 20:22:10 | Re: SSI error messages |