Skip site navigation (1) Skip section navigation (2)

Re: Altering column collation

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Thom Brown <thom(at)linux(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Altering column collation
Date: 2011-07-19 07:32:35
Message-ID: 1311060755.2036.5.camel@laptop (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Tue, 2011-07-19 at 00:48 +0100, Thom Brown wrote:
> [...]
> Attached is a patch which fixes #328.  Currently if you change a
> column's collation, it actually drops the column.  This changes it so
> that it issues an ALTER TYPE to adjust the collation instead.
> 

Pushed on master. Thanks for yet another patch :)

I didn't push it on 1.14 yet. The patch doesn't work here, and I guess
it's because I didn't push your previous patch. I'm not sure on the best
move here. Should we simply remove the bug (no change detected when
changing collation on the column properties dialog)? or should we apply
both patches (which will give us bugfix, and better handling of
columns)? Any ideas?


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2011-07-19 07:47:54
Subject: Re: Website
Previous:From: Guillaume LelargeDate: 2011-07-19 07:28:59
Subject: pgAdmin III commit: Fix weird behaviour when changing column'scollatio

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group