Skip site navigation (1) Skip section navigation (2)

Re: Prevent duplicate attributes

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Thom Brown <thom(at)linux(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Prevent duplicate attributes
Date: 2011-07-14 09:24:31
Message-ID: 1310635472.2073.7.camel@laptop (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Tue, 2011-07-12 at 11:17 +0100, Thom Brown wrote:
> On 12 July 2011 11:11, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
> > On Tue, 2011-07-12 at 10:55 +0100, Thom Brown wrote:
> >> On 12 July 2011 10:53, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >> > On Sat, Jul 9, 2011 at 9:02 PM, Thom Brown <thom(at)linux(dot)com> wrote:
> >> >> Hi (yes, me... again),
> >> >>
> >> >> Tiny patch attached to prevent adding attributes with a duplicate name
> >> >> to a type.  It seems previous versions prevented this, but must have
> >> >> been allowed in a commit since the last release.
> >> >
> >> > For consistency with the other checks on the dialogue, this should
> >> > cause the "Add" button to be disabled, not make it silently fail. That
> >> > should almost certainly be done in dlgType::CheckChange().
> >>
> >> Yes, you're right.
> >>
> >
> > Does this patch need to be applied after the "overhaul of type
> > attributes" one?
> 
> No, as this patch shouldn't be applied at all since, as Dave pointed
> out, the duplicate check should appear in CheckChange().  This is an
> existing bug unrelated to the type attribute changes patch.  I just
> noticed it while testing my changes.
> 

So, you're working on fixing it, right?


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2011-07-14 09:28:58
Subject: Re: Overhaul of type attributes modification
Previous:From: Guillaume LelargeDate: 2011-07-14 09:22:48
Subject: Re: Overhaul of type attributes modification

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group