Skip site navigation (1) Skip section navigation (2)

Re: BUG #6066: [PATCH] Mark more strings as c-format

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Christoph Berg <cb(at)df7cb(dot)de>
Cc: pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #6066: [PATCH] Mark more strings as c-format
Date: 2011-06-17 14:21:48
Message-ID: 1308320438-sup-7603@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-bugs
Excerpts from Christoph Berg's message of vie jun 17 07:10:34 -0400 2011:
> Re: To pgsql-bugs(at)postgresql(dot)org 2011-06-17 <20110617091114(dot)GC4130(at)msgid(dot)df7cb(dot)de>
> > Unfortunately that doesn't help in this case, as the bad string isn't
> > tagged as "#, c-format", but still gets used as such. This seems to be
> > the case for many errhint() strings. Maybe xgettext should be taught
> > to treat all errhint() et al arguments as c-strings.
> 
> Here's a patch to implement that, with backend/nls.mk updated.
> 
> msgfmt -c is already available in the "maintainer-check-po" target.
> I'd assume this was called at least once during the release process.

Yeah, msgfmt -c is called pretty frequently on the translation service
http://babel.postgresql.org.

Thanks for the patch, I'll have a look at integrating it.

-- 
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

pgsql-bugs by date

Next:From: Tom LaneDate: 2011-06-17 14:28:06
Subject: Re: BUG #6065: FATAL: lock 0 not held
Previous:From: Kevin GrittnerDate: 2011-06-17 14:20:47
Subject: Re: BUG #6064: != NULL, <> NULL do not work

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group