Skip site navigation (1) Skip section navigation (2)

Re: Discussion - Search Objects

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Jasmin Dizdarevic <jasmin(dot)dizdarevic(at)gmail(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Discussion - Search Objects
Date: 2011-06-15 21:38:55
Message-ID: 1308173936.1993.90.camel@laptop (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Wed, 2011-06-15 at 08:08 +0200, Guillaume Lelarge wrote:
> On Wed, 2011-06-15 at 01:03 +0200, Jasmin Dizdarevic wrote:
> > Hi, 
> > 
> > 
> > please take another look on it. The UI should work correctly now.
> > 
> > 
> > Linux make files should also be correct now.
> > 
> 
> It works much better now. You still have one issue with primary key (and
> I guess, unique constraint and exclusive constraints too). You show them
> as constraints and indexes, whereas pgAdmin only shows them as
> constraints. You shouldn't display indexes for constraints with implicit
> indexes.
> 
> And I didn't look at the code yet.
> 

Seems mostly good. The only question I have is: why did you choose to
name it frm* instead of dlg*? it behaves as a dialog, not as a form.


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


In response to

Responses

pgadmin-hackers by date

Next:From: Jasmin DizdarevicDate: 2011-06-15 21:48:26
Subject: Re: Discussion - Search Objects
Previous:From: Guillaume LelargeDate: 2011-06-15 21:30:05
Subject: Re: Ownership of a new view

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group