Skip site navigation (1) Skip section navigation (2)

Re: Database bar

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Erwin Brandstetter <brandstetter(at)falter(dot)at>
Cc: "pgadmin-hackers(at)postgresql(dot)org" <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Database bar
Date: 2011-06-13 12:56:32
Message-ID: 1307969793.1969.9.camel@laptop (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Mon, 2011-06-13 at 00:36 +0200, Erwin Brandstetter wrote:
> On 12.06.2011 08:59, Guillaume Lelarge wrote:
> > On Sat, 2011-06-11 at 22:24 +0200, Erwin Brandstetter wrote:
> >> On 11.06.2011 18:16, Guillaume Lelarge wrote:
> >>> On Sat, 2011-06-11 at 18:13 +0200, Erwin Brandstetter wrote:
> >>>> On 11.06.2011 17:17, Guillaume Lelarge wrote:
> >>>>> On Sat, 2011-06-11 at 16:02 +0200, Erwin Brandstetter wrote:
> >>>>>> On 28.05.2011 15:56, Guillaume Lelarge wrote:
> >> (...)
> >>>>>>> So, I finally did some fixes:
> >>>>>>>
> >>>>>>> * "Database bar" has been renamed to "Connection bar".
> >>>>>>> * The connection bar is larger. (check if it is enough, it's quite hard
> >>>>>>>       to be sure of it)
> >>>>>>> * The connection name doesn't contain the rolename.
> >>>>>> I tried the new 1.14 beta2 on Win XP today.
> >>>>>> "Connection bar" has arrived.
> >>>>>> But the control is exactly the same size as it was in 1.12.3. The growth
> >>>>>> got lost somehow?
> >>>>>>
> >>>>> Strange. Can you check your Perspective setting in the frmQuery group?
> >>>>> Empty it and relaunch pgAdmin.
> >>>> Sorry, I don't know what that means.
> >>>> Are you referring to the source code? I have only donwnloaded the
> >>>> provided binary ...
> >>>>
> >>> I think you don't have the new size because the old one is recorded in
> >>> your preferences. On Windows, it's stored in the registry. Can you look
> >>> with regedit, find the Perspective value of the frmQuery group, and
> >>> delete it?
> >>>
> >>> If you've never used regedit, it's probably better not to.
> >> Ah, registry settings.
> >> Most people will update from a previous version and run into the same
> >> problem ..
> >>
> > I know that. It seems I forgot to increment the perspective number. But
> > I won't do only that if the rest is wrong too.
> >
> >> I have 12 entries named perspective-.* I attached the names and values
> >> for the first and last one. Which am I supposed to delete? All of them?
> > All of them would be better, but you can only delete the 8316 one.
> >
> >> These values are just to remember the previous state of the GUI, I am
> >> not losing other settings, right?
> > The perspective is only for location, and size of the different panes.
> > In the frmQuery group, it only refers to the query tool.
> >
> >> In case this should be relevant: I have installed pgAdmin  1.10, 1.12,
> >> and 1.14 in parallel on the PC in question.
> >>
> > That should not be an issue. They all have a different perspective name
> > (hence, the perspective-<number>). In this case, just drop the
> > perspective-8316.
> >
> >> What's confusing: the size of the connection bar cannot be adjusted in
> >> any way, so why save it to the registry?
> > The perspective is a whole. Either you save all locations, and sizes of
> > the panes of this window, or you save nothing. At least, that was the
> > case when I last read the wxWidgets documentation.
> 
> 
> Your theory is probably right. After deleting all "Perspective-*" 
> entries from the registry, the Connection bar is now broader. The new 
> size works just fine.

OK, I've commited a patch with an increment on the perspective number.
Thanks.

> BTW: would it be an option to let the user adjust the size or even 
> auto-adjust to the longest entry? (Just ideas.)

Don't know if it's possible at all.

> After closing pgAdmin a new entry "perspective-8316" landed in the 
> registry. I paste it here, in case you should need it.
> Those should be vanilla values, I only checked on the size of the 
> Connection bar and did not make any adjustments.
> 
> layout2|name=toolBar;caption=Tool 
> bar;state=16788208;dir=1;layer=10;row=0;pos=0;prop=100000;bestw=415;besth=23;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=databaseBar;caption=Connection 
> bar;state=16788208;dir=1;layer=10;row=0;pos=426;prop=100000;bestw=300;besth=21;minw=-1;minh=-1;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=outputPane;caption=Output 
> pane;state=16779260;dir=3;layer=0;row=0;pos=0;prop=100000;bestw=550;besth=300;minw=200;minh=100;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=scratchPad;caption=Scratch 
> pad;state=16779260;dir=2;layer=0;row=0;pos=0;prop=100000;bestw=250;besth=200;minw=100;minh=100;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|name=sqlQuery;caption=SQL 
> query;state=1020;dir=5;layer=0;row=0;pos=0;prop=100000;bestw=350;besth=200;minw=200;minh=100;maxw=-1;maxh=-1;floatx=-1;floaty=-1;floatw=-1;floath=-1|dock_size(1,10,0)=25|dock_size(5,0,0)=202|dock_size(3,0,0)=290|dock_size(2,0,0)=255|
> 

That's the good new perspective. bestw's value is now 300 for the
database bar.


-- 
Guillaume
  http://blog.guillaume.lelarge.info
  http://www.dalibo.com


In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2011-06-13 12:59:54
Subject: pgAdmin III commit: Automatic merge using stringmerge script.
Previous:From: Guillaume LelargeDate: 2011-06-13 12:55:07
Subject: pgAdmin III commit: Forgot to increment the perspective number

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group