Re: WIP patch - INSERT-able log statements

From: "FAST PostgreSQL" <fastpgs(at)fast(dot)fujitsu(dot)com(dot)au>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com>, "Greg Smith" <gsmith(at)gregsmith(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: WIP patch - INSERT-able log statements
Date: 2007-02-22 01:43:32
Message-ID: 13067.11471172022210.fast.fujitsu.com.au@MHS
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Wed, 21 Feb 2007 12:08, Tom Lane wrote:
> "FAST PostgreSQL" <fastpgs(at)fast(dot)fujitsu(dot)com(dot)au> writes:
> > - The log output will be in COPY format and will include the following
> > information, irrespective of the log_line_prefix setting.
> > ( timestamp_with_milliseconds,  timestamp, username,  databasename,
> > sessionid,  host_and_port, host, proc_id, command_tag,  session_start,
> > transaction_id,  error_severity,  SQL_State_Code,
> > statement/error_message);
>
> How exactly are you fitting the message structure
> (primary/detail/context lines) into this? It looks like your proposal
> loses that structure ...

Sorry, didn't understand.... Can you please elaborate ?

> A smaller problem is that this forces people to incur a gettimeofday
> call for every message logged; depending on your hardware that can be a
> pretty nasty overhead. Some people might find some of the other columns
> not worth their weight, either. Is it worth providing a knob to
> determine the set of columns emitted?

Totally agree. My original patch infact uses log_line_prefix. So the user can
fill in the columns he wants by turning on appropriate settings in
log_line_prefix. The columns which he hasn't turned on will be output as NULL
in the sql outptut.

But I can also see merit in others' request that it is ideal to have all
possible info in the sql log, so that once the log is loaded into the table,
it can be queried, sub-tabled, created view to analyze it in whatever way.....

Rgds,
Arul Shaji

>
> regards, tom lane
This is an email from Fujitsu Australia Software Technology Pty Ltd, ABN 27 003 693 481. It is confidential to the ordinary user of the email address to which it was addressed and may contain copyright and/or legally privileged information. No one else may read, print, store, copy or forward all or any of it or its attachments. If you receive this email in error, please return to sender. Thank you.

If you do not wish to receive commercial email messages from Fujitsu Australia Software Technology Pty Ltd, please email unsubscribe(at)fast(dot)fujitsu(dot)com(dot)au

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message elein 2007-02-22 02:06:50 Re: Column storage positions
Previous Message Gavin Sherry 2007-02-22 01:39:08 Re: Status of Hierarchical Queries

Browse pgsql-patches by date

  From Date Subject
Next Message FAST PostgreSQL 2007-02-22 04:25:19 Re: WIP patch - INSERT-able log statements
Previous Message FAST PostgreSQL 2007-02-22 00:50:06 Re: WIP patch - INSERT-able log statements