Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Allow ALTER TABLE name {OF type | NOT OF}.

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Allow ALTER TABLE name {OF type | NOT OF}.
Date: 2011-05-28 01:53:52
Message-ID: 1306547533-sup-1249@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Excerpts from Cédric Villemain's message of vie may 27 18:37:05 -0400 2011:
> 2011/4/21 Robert Haas <rhaas(at)postgresql(dot)org>:

> > Modified Files
> > --------------
> > doc/src/sgml/ref/alter_table.sgml         |   26 +++
> > src/backend/commands/tablecmds.c          |  277 +++++++++++++++++++++++++++--
> 
> I noticed 2 warnings on unused variables from gcc in tablecmds.c
> The attached patch fix that by removing those 2 variables.

My compiler wasn't complaining, but since the variable is clearly unused
I went ahead and pushed this.  Thanks

-- 
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-hackers by date

Next:From: MauMauDate: 2011-05-28 03:42:39
Subject: Re: What is the best and easiest implementation to reliably wait for the completion of startup?
Previous:From: Tom LaneDate: 2011-05-28 01:53:49
Subject: Re: dblink crash on PPC

pgsql-committers by date

Next:From: Cédric VillemainDate: 2011-05-28 07:05:17
Subject: Re: [COMMITTERS] pgsql: Allow ALTER TABLE name {OF type | NOT OF}.
Previous:From: Alvaro HerreraDate: 2011-05-28 01:51:57
Subject: pgsql: Remove unused variable

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group