Re: [PATCHES] CIC and deadlocks

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] CIC and deadlocks
Date: 2008-03-17 16:23:06
Message-ID: 13046.1205770986@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com> writes:
> [ patch to reduce probability of deadlock of CREATE INDEX CONCURRENTLY
> with other things ]

This patch no longer applies because of the VirtualXid changes.
Looking at it again, I'm fairly dissatisfied with it anyway;
I really don't like moving the GetTransactionSnapshot calls around
like that, because it opens a risk that GetTransactionSnapshot won't
get called at all.

Since the autovacuum case is already dealt with separately, I'm
thinking there is no problem here that we actually need to solve.
C.I.C. can never be guaranteed free of deadlock risk, so I don't
see a lot of value in making it free of deadlock risk against
just CLUSTER and VACUUM FULL.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2008-03-17 16:31:32 Re: Commit fest?
Previous Message Gregory Stark 2008-03-17 16:16:14 Re: Rewriting Free Space Map

Browse pgsql-patches by date

  From Date Subject
Next Message Greg Smith 2008-03-17 16:52:27 Re: [PATCHES] [0/4] Proposal of SE-PostgreSQL patches
Previous Message Peter Eisentraut 2008-03-17 16:10:41 Re: Minimum selectivity estimate for LIKE 'prefix%'