On ons, 2011-05-04 at 20:32 +0200, Magnus Hagander wrote:
> Is this part really correct?
> - fprintf(stderr, _("%s: final receive failed: %s\n"),
> + fprintf(stderr, _("%s: final receive failed: %s"),
> all other msgs have \n.. I see you removed the final dot in many of
> the other messages, did you just accidentally grab one too many?
> (There are a couple of other examples of removing the \n though, so
> perhaps it was intentional? But they're all preceeding
> disconnect_and_exit() so I don't see why it shouldn't be consistent?
The result of PQerrorMessage() already ends in \n.
With that in mind, maybe I missed something?
In response to
pgsql-hackers by date
|Next:||From: Kevin Grittner||Date: 2011-05-04 19:15:15|
|Subject: Re: 'SGT DETAIL: Could not open file "pg_clog/05DC": No such file or directory' - what to do now?|
|Previous:||From: Tom Lane||Date: 2011-05-04 18:50:35|
|Subject: Re: Extreme bloating of intarray GiST indexes |
pgsql-committers by date
|Next:||From: Magnus Hagander||Date: 2011-05-04 19:16:42|
|Subject: Re: [COMMITTERS] pgsql: Message style cleanup|
|Previous:||From: Tom Lane||Date: 2011-05-04 19:02:49|
|Subject: pgsql: Include unary plus in the Operator Precedence table.|