Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64
Date: 2011-04-27 19:08:29
Message-ID: 1303931274-sup-6567@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Excerpts from Tom Lane's message of lun abr 25 17:22:41 -0300 2011:
> Fix pg_size_pretty() to avoid overflow for inputs close to INT64_MAX.
> 
> The expression that tried to round the value to the nearest TB could
> overflow, leading to bogus output as reported in bug #5993 from Nicola
> Cossu.  This isn't likely to ever happen in the intended usage of the
> function (if it could, we'd be needing to use a wider datatype instead);
> but it's not hard to give the expected output, so let's do so.

Apparently this change is causing Moa's SunStudio compiler to fail an
assertion.

-- 
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2011-04-27 19:12:52
Subject: Re: Alpha4 release blockers (was Re: wrapping up this CommitFest)
Previous:From: Andrew DunstanDate: 2011-04-27 19:05:30
Subject: Re: XML with invalid chars

pgsql-committers by date

Next:From: Peter EisentrautDate: 2011-04-27 19:11:31
Subject: pgsql: Fix binary upgrade of altered typed tables
Previous:From: Andrew DunstanDate: 2011-04-27 18:57:32
Subject: pgsql: Revert "Force use of "%I64d" format for 64 bit ints on MinGW."

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group