Re: equal() perf tweak

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: equal() perf tweak
Date: 2003-11-03 23:19:29
Message-ID: 13039.1067901569@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> Do you think it would be worth the trouble to use both algorithms, and
> then test on the node tag of the first element to decide which one to
> use? (The assumption being lists are homogeneous).

Hard to tell. Since I haven't seen any evidence that equal() on lists
is a particular hotspot, I'd lean against adding complexity and
maintenance burden here.

> One thing I've been wondering about is whether it would be worth ripping
> out the existing List code wholesale, and replacing it with something
> like the following:

I have already done something much like this in a few hotspots using the
FastList structure. But notationally, it's a pain in the neck compared
to the existing List code. If you can think of a way to implement this
without adding a lot of notational cruft, I'd sure be for it. I'm not
for it if it imposes as much messiness as the FastList approach does...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-11-03 23:38:01 Re: adding support for posix_fadvise()
Previous Message Gaetano Mendola 2003-11-03 23:17:29 Re: 7.4RC1 tag'd, branched and bundled ...

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-11-03 23:46:12 Re: bufmgr code cleanup
Previous Message Larry Rosenman 2003-11-03 23:09:38 Re: UW 713UP3 patch