Re: make check in contrib

On mån, 2011-04-25 at 11:22 -0400, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Mon, Apr 25, 2011 at 10:21 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> >>> On Sun, Apr 24, 2011 at 7:18 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> >>>> I noticed again that make check in contrib doesn't work, so here is a
> >>>> patch to fix it.
>
> >>> I think it might be more useful to have a check target that actually
> >>> succeeds, even if it does nothing useful.
>
> >> That argument seems a bit irrelevant to the proposed patch.
>
> > How so?
>
> The proposed patch is to fix it, not remove it. Surely that's more
> useful than a no-op target.

The proposed patch will support make check for contrib modules, but not
for external users of pgxs.