pg_upgrade exit_nicely()

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: pg_upgrade exit_nicely()
Date: 2011-03-31 20:31:33
Message-ID: 1301603493.9296.28.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

While reading around in pg_upgrade code I came across the slightly
bizarre function

void exit_nicely(bool need_cleanup)

The parameter doesn't actually determine whether any cleanup is done.
The "cleanup" is done anyway and the parameter only controls the exit
code in a backwards way.

Also most of the cleanup appears to be useless, because you don't need
to close files or free memory before the program exits.

I figured this could be written more cleanly with an exit hook, so here
is a patch. I don't care much whether this patch is for now or later,
just wanted to throw it out there.

Attachment Content-Type Size
pgupgrade-exit.diff text/x-patch 5.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-03-31 20:35:01 Re: Bug in autovacuum.c?
Previous Message Robert Haas 2011-03-31 20:27:54 cast from integer to money