From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc:
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, Peter Eisentraut <peter_e(at)gmx(dot)net>,
pgsql-hackers(at)postgresql(dot)org,
ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Subject:
Re: generic reloptions improvement
Date:
2009-01-04 23:37:08
Message-ID:
1301.1231112228@sss.pgh.pa.us (view raw or flat )
Thread:
2008-12-19 21:55:19 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2008-12-20 03:40:57 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2008-12-22 02:36:55 from ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
2008-12-22 16:24:53 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2008-12-24 10:38:26 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2008-12-24 11:01:05 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2008-12-24 16:16:33 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2008-12-29 03:26:36 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2008-12-30 15:31:14 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-01-03 12:42:08 from KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
2009-01-03 15:17:32 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-01-03 15:59:37 from KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
2009-01-03 16:26:22 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-01-04 04:01:15 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-01-04 21:31:08 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-01-04 22:01:21 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-01-04 23:10:49 from "Alex Hunsaker" <badalex(at)gmail(dot)com>
2009-01-05 01:46:54 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-01-04 23:37:08 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-05 00:44:49 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-05 01:40:59 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-01-05 02:42:31 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-05 13:57:55 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-01-03 13:46:51 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2009-01-03 15:20:43 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-01-03 15:54:58 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2009-01-03 16:32:14 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2009-01-04 21:36:11 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Lists:
pgsql-hackers
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> This is the patch in its final form. I have included a few macros to
> simplify the writing of amoptions routines.
Minor gripes:
* Does initialize_reloptions() need to be exported? It seems to be
only called within parseRelOptions(). It's far from clear who else
should be expected to call it.
* The HANDLE_ macros are dangerous as-is (dangling if/else). Need to
use the usual do/while trick.
regards, tom lane
In response to
pgsql-hackers by date
Next :From: Hitoshi HaradaDate: 2009-01-05 00:16:23Subject : Re: WIP patch for basic window frame supportPrevious :From : Alex HunsakerDate : 2009-01-04 23:32:44Subject : [PATCH] ALTER TABLE SET (compress_max_size... = )
