| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Daniel Popowich <danielpopowich(at)gmail(dot)com> |
| Cc: | pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #5842: Memory leak in PL/Python when taking slices of results |
| Date: | 2011-03-17 18:31:08 |
| Message-ID: | 1300386599-sup-6152@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Excerpts from Daniel Popowich's message of mar ene 18 13:30:04 -0300 2011:
> I traced the bug to PLy_result_slice() in src/pl/plpython/plpython.c. That
> function calls the python API function PyList_GetSlice() and erroneously
> increments the reference count before returning the result to the caller.
> PyList_GetSlice returns a *new* reference, not a borrowed one, so it should
> just return the object as-is.
>
> A patch is attached below.
Thanks, applied and backpatched all the way back to 8.2.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Brad Nicholson | 2011-03-17 19:36:27 | BUG #5935: Log lotation not working for default log format |
| Previous Message | Alvaro Herrera | 2011-03-17 15:15:30 | Re: Re: [BUGS] BUG #5842: Memory leak in PL/Python when taking slices of results |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-03-17 18:38:17 | Re: Flex output missing from 9.1a4 tarballs? |
| Previous Message | Peter Eisentraut | 2011-03-17 18:25:51 | Re: why is max standby delay only 35 minutes? |