On Mon, 2011-03-07 at 17:44 +0900, Fujii Masao wrote:

> The above check should be required also after pg_ctl reload since
> synchronous_standby_names can be changed by SIGHUP?
> Or how about just removing that? If the patch I submitted is
> committed,empty synchronous_standby_names and max_wal_senders = 0
> settings is no longer unsafe.

Ah, on reload. I plugged the gap only at startup.

I'll fix by changing assign_synchronous_standby_names(), not by changing
lots of other parts of code and making runtime check each COMMIT.

-- 
 Simon Riggs           http://www.2ndQuadrant.com/books/
 PostgreSQL Development, 24x7 Support, Training and Services
 

In response to

• Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication. at 2011-03-07 08:44:52 from Fujii Masao

Responses

• Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication. at 2011-03-07 09:47:20 from Fujii Masao

pgsql-hackers by date

Next:	From: Heikki Linnakangas	Date: 2011-03-07 09:31:22
	Subject: Re: Composite Index Structure
Previous:	From: Fujii Masao	Date: 2011-03-07 09:28:25
	Subject: Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.

pgsql-committers by date

Next:	From: Fujii Masao	Date: 2011-03-07 09:47:20
	Subject: Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.
Previous:	From: Fujii Masao	Date: 2011-03-07 09:28:25
	Subject: Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.