Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Efficient transaction-controlled synchronous replication.

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Efficient transaction-controlled synchronous replication.
Date: 2011-03-07 09:20:07
Message-ID: 1299489607.1696.7933.camel@ebony (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Mon, 2011-03-07 at 17:27 +0900, Fujii Masao wrote:
> On Mon, Mar 7, 2011 at 7:51 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:

> And,, I found one bug ;) You seem to have wrongly removed the check
> of max_wal_senders in SyncRepWaitForLSN. This can make the
> backend wait for replication even if max_wal_senders = 0. I could produce
> this problematic situation in my machine. The attached patch fixes this problem.

There may be a bug, but that's not the fix.

I spotted that issue myself in testing. I put in a protection to stop
setting synchronous_standby_names if max_wal_senders is zero, with error
message.

Are you saying the committed version doesn't trigger that ERROR?

-- 
 Simon Riggs           http://www.2ndQuadrant.com/books/
 PostgreSQL Development, 24x7 Support, Training and Services
 


In response to

Responses

pgsql-hackers by date

Next:From: Fujii MasaoDate: 2011-03-07 09:28:25
Subject: Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.
Previous:From: Nick RajDate: 2011-03-07 09:11:25
Subject: Re: Composite Index Structure

pgsql-committers by date

Next:From: Fujii MasaoDate: 2011-03-07 09:28:25
Subject: Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.
Previous:From: Heikki LinnakangasDate: 2011-03-07 08:47:49
Subject: pgsql: Document the DEFERRABLE option in SET TRANSACTION command.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group