Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Exit from base backups when shutdown is requested

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Exit from base backups when shutdown is requested
Date: 2011-01-14 12:25:03
Message-ID: 1295007903.12442.76.camel@ebony (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Fri, 2011-01-14 at 14:16 +0200, Heikki Linnakangas wrote:
> On 14.01.2011 14:10, Simon Riggs wrote:
> > Please make that the last commit in this area for next week.
> >
> > I want to get a base from which to solidify the sync rep code, and
> > associated patches.
> >
> > I'm not saying there will be a code clash, but there may be a clash of
> > detail or intention that will make life more difficult for testing.
> 
> I'm sorry, but it doesn't work that way. There's at least one serious 
> bug in there still 

I'm not clear why you haven't submitted this code to the CommitFest,
especially if it clearly hasn't been very well tested.

> None of that should conflict seriously with the synch rep code, although 
> it's hard to tell without seeing the patch. And even if it does, we'll 
> just resolve the conflict, merge conflicts are not such a big deal.

It's even easier if you don't cause them in the first place.

My request is not unreasonable. Please be helpful, as you would expect
me to be if the roles were reversed.

-- 
 Simon Riggs           http://www.2ndQuadrant.com/books/
 PostgreSQL Development, 24x7 Support, Training and Services
 


In response to

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2011-01-14 12:27:58
Subject: Re: Recovery control functions
Previous:From: Shigeru HANADADate: 2011-01-14 12:23:59
Subject: Re: SQL/MED - FDW API

pgsql-committers by date

Next:From: Robert HaasDate: 2011-01-14 12:30:03
Subject: Re: Re: [COMMITTERS] pgsql: Exit from base backups when shutdown is requested
Previous:From: Magnus HaganderDate: 2011-01-14 12:21:05
Subject: Re: [COMMITTERS] pgsql: Exit from base backups when shutdown is requested

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group