comments on type attributes broken in 9.1devel

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: comments on type attributes broken in 9.1devel
Date: 2010-10-19 05:46:45
Message-ID: 1287467205.31811.4.camel@fsopti579.F-Secure.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The comment code refactoring c10575ff005c330d0475345621b7d381eb510c48
broke comments on composite type attributes:

COMMENT ON COLUMN foo.a is 'test';
ERROR: 42809: "foo" is a composite type
LOCATION: heap_openrv, heapam.c:1110

This is because as the code was moved from CommentAttribute() to
get_object_address_attribute(), the call to relation_openrv() became a
heap_openrv(), which causes the above error.

Please check it out.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2010-10-19 05:56:32 Re: Timeout and wait-forever in sync rep
Previous Message Fujii Masao 2010-10-19 05:24:14 Re: Timeout and wait-forever in sync rep