Re: [GENERAL] Empty arrays with ARRAY[]

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Brendan Jurd" <direvus(at)gmail(dot)com>
Cc: "Martijn van Oosterhout" <kleptog(at)svana(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [GENERAL] Empty arrays with ARRAY[]
Date: 2007-11-27 22:49:33
Message-ID: 12813.1196203773@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers pgsql-patches

"Brendan Jurd" <direvus(at)gmail(dot)com> writes:
> I actually thought that A_ArrayExpr would be a good addition even if
> you ignore the matter of typecasting. It always seemed weird to me
> that the parser generates an ArrayExpr directly. ArrayExpr has a
> bunch of members that are only set by the transform; all the parser
> does is set the 'elements' member.

Well, that's a reasonable argument. And now that I think about it,
a parser-only node type doesn't have nearly the support overhead that
a full-fledged executable node does. So no objection to A_ArrayExpr
if you want to do that.

> I had a bit of a dig into this. A_Const->typename gets set directly
> by the parse paths for "INTERVAL [(int)] string [interval range]". In
> fact, as far as I can tell that's the _only_ place A_Const->typename
> gets used at all.

Uh, you missed quite a lot of others ... see CURRENT_DATE and a lot of
other productions.

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Galkowski, Jan 2007-11-27 23:02:49 spatial composition operators for PG
Previous Message Brendan Jurd 2007-11-27 21:53:42 Re: [GENERAL] Empty arrays with ARRAY[]

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-11-27 23:06:52 Re: Quality and Performance
Previous Message Andrew Dunstan 2007-11-27 22:45:06 Re: Quality and Performance

Browse pgsql-patches by date

  From Date Subject
Next Message Brendan Jurd 2007-11-27 23:57:14 Re: [GENERAL] Empty arrays with ARRAY[]
Previous Message Brendan Jurd 2007-11-27 21:53:42 Re: [GENERAL] Empty arrays with ARRAY[]