Re: [PATCH] Re: Adding xpath_exists function

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Mike Fowler <mike(at)mlfowler(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Re: Adding xpath_exists function
Date: 2010-08-06 02:29:10
Message-ID: 1281061552-sup-8773@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-rrreviewers

Excerpts from Mike Fowler's message of mar jun 29 06:37:28 -0400 2010:

> After seeing some other posts in the last couple of days, I realised I
> hadn't documented the function in the SGML. I have now done so, and
> added a couple of tests with XML literals. Please find the patch
> attached. Now time to go correct the xmlexists patch too...

Hmm, is 0 a valid node number in a xmlNodeSet? If it is, searching for
the zeroth node would make the code call PG_RETURN_BOOL(0), no?

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2010-08-06 02:44:30 Re: BUG #5599: Vacuum fails due to index corruption issues
Previous Message Robert Haas 2010-08-06 02:11:20 LockDatabaseObject vs. LockSharedObject

Browse pgsql-rrreviewers by date

  From Date Subject
Next Message Peter Eisentraut 2010-08-06 04:38:12 Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function
Previous Message Kevin Grittner 2010-08-05 18:42:54 CommitFest 2010-07 week three progress report