Skip site navigation (1) Skip section navigation (2)

Re: BUG #5599: Vacuum fails due to index corruption issues

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Hitesh Bhambhani <hitesh(dot)bhambhani(at)asg(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #5599: Vacuum fails due to index corruption issues
Date: 2010-08-05 16:57:46
Message-ID: 1281027356-sup-6865@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
Excerpts from Tom Lane's message of jue ago 05 12:36:24 -0400 2010:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Excerpts from Tom Lane's message of jue ago 05 11:06:57 -0400 2010:
> >> 1. Write the dirty buffers before dropping them.  Kind of ugly from a
> >> performance viewpoint, but simple and safe.
> 
> > I think "simple" is good, considering that this code is gone in 9.0 and
> > HEAD.  IMHO investing too much effort on this problem is not worth it.
> 
> Gone?  Looks like it's still there to me.

I mean the btree code that does the truncation on vacuum full is
truncated.  There are other uses for truncation, but it doesn't look to
that they are as problematic ... or are they?

Hmm, I guess truncation of heap on lazy vacuum is still a problem
precisely because page compaction will be forgotten.

> > Perhaps it'd be good to come up with a better solution for HEAD:
> 
> Yeah, the panic-on-replay aspect is troublesome.  I feel like we need a
> rethink here.  But I agree that solution #1 is the only one that feels
> safe enough for backpatching.

-- 
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-hackers by date

Next:From: Kevin GrittnerDate: 2010-08-05 16:57:51
Subject: Re: Concurrent MERGE
Previous:From: pgsql-hackersDate: 2010-08-05 16:55:13
Subject: pgsql-hackers@news.hub.org 50% OFF on Pfizer!

pgsql-bugs by date

Next:From: Tom LaneDate: 2010-08-05 17:19:41
Subject: Re: BUG #5599: Vacuum fails due to index corruption issues
Previous:From: Tom LaneDate: 2010-08-05 16:49:52
Subject: Re: BUG #5602: Recovering from Hot-Standby file backup leads to the currupted indexes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group