| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: missing "else" in postmaster.c? |
| Date: | 2010-06-22 17:21:09 |
| Message-ID: | 1277227207-sup-5889@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Excerpts from Robert Haas's message of lun jun 21 22:18:46 -0400 2010:
> In pmdie(), we have the following code, which doesn't seem to make
> much sense. If the state is PM_RECOVERY at the top of this section it
> will get changed to PM_WAIT_BACKENDS and then to PM_WAIT_BACKENDS
> again. Either the two "if" statements should be merged (and both bits
> should be handled with the same block of code) or the second one
> should say "else if". Or at least, I think so...
I'd just move the first block below the second one.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Florian Pflug | 2010-06-22 17:30:55 | Re: TCP keepalive support for libpq |
| Previous Message | Mike Fowler | 2010-06-22 17:17:46 | Re: Adding XMLEXISTS to the grammar |