Skip site navigation (1) Skip section navigation (2)

Re: Revised patches to add table function support to PL/Tcl (TODO item)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Karl Lehenbauer <karllehenbauer(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject: Re: Revised patches to add table function support to PL/Tcl (TODO item)
Date: 2010-12-29 00:29:42
Message-ID: 12765.1293582582@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Karl Lehenbauer <karllehenbauer(at)gmail(dot)com> writes:
> The first patch, pltcl-karl-try2-1-of-3-pgindent.patch, does nothing but conform HEAD's pltcl.c with pgindent.  Applying this patch should have exactly the same effect as running  
> 	src/tools/pgindent/pgindent src/tools/pgindent/typedefs.list src/pl/tcl/pltcl.c

This patch appears to be changing a whole lot of stuff that in fact
pg_indent has never changed, so there's something wrong with the way you
are doing it.  It looks like a bad typedef list from here.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Joel JacobsonDate: 2010-12-29 01:18:46
Subject: Re: pg_dump --split patch
Previous:From: Tom LaneDate: 2010-12-29 00:24:57
Subject: Re: pg_dump --split patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group