Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Ensure that top level aborts call XLogSetAsyncCommit().

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Ensure that top level aborts call XLogSetAsyncCommit().
Date: 2010-05-31 11:48:43
Message-ID: 1275306523.6558.539.camel@ebony (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Mon, 2010-05-31 at 20:11 +0900, Fujii Masao wrote:
> On Thu, May 13, 2010 at 8:39 PM, Simon Riggs <sriggs(at)postgresql(dot)org> wrote:
> > Log Message:
> > -----------
> > Ensure that top level aborts call XLogSetAsyncCommit(). Not doing
> > so simply leads to data waiting in wal_buffers which then causes
> > later commits to potentially do emergency writes and for all forms
> > of replication to be potentially delayed without need or benefit.
> > Issue pointed out exactly by Fujii Masao, following bug report
> > by Robert Haas on a separate though related topic.
> >
> > Modified Files:
> > --------------
> >    pgsql/src/backend/access/transam:
> >        xact.c (r1.290 -> r1.291)
> >        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xact.c?r1=1.290&r2=1.291)
> 
> This commit changed XLogSetAsyncCommitLSN() so that it's called
> for abort case. So we need to change the comment of the function
> as follows:

Agreed, will fix.

Will also rename function to better document its new role.

-- 
 Simon Riggs           www.2ndQuadrant.com


In response to

Responses

pgsql-hackers by date

Next:From: Thom BrownDate: 2010-05-31 13:22:17
Subject: Re: PG 9.0 release timetable
Previous:From: Fujii MasaoDate: 2010-05-31 11:11:47
Subject: Re: [COMMITTERS] pgsql: Ensure that top level aborts call XLogSetAsyncCommit().

pgsql-committers by date

Next:From: Bruce MomjianDate: 2010-05-31 15:50:49
Subject: pgsql: Reword fsync and full_page_writes docs to be clearer about when
Previous:From: Fujii MasaoDate: 2010-05-31 11:11:47
Subject: Re: [COMMITTERS] pgsql: Ensure that top level aborts call XLogSetAsyncCommit().

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group