| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Joachim Wieland <joe(at)mcknight(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: Hot Standby and query cancel |
| Date: | 2010-01-14 12:21:07 |
| Message-ID: | 1263471667.26654.20178.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2010-01-13 at 19:23 +0000, Simon Riggs wrote:
> On Wed, 2010-01-13 at 19:58 +0100, Andres Freund wrote:
>
> > > I am still testing patch, so should be confident to commit tomorrow
> > > barring issues.
> > I have only looked at briefly because right now I dont have the time (going to
> > eat at a friends place...) but I think I spotted an issue:
> > The IsAbortedTransactionBlockState() check in RecoveryConflictInterrupt is not
> > correct right now because that returns true for TBLOCK_SUBABORT as well.
> > Wouldnt that mess with the case where were in a failed subxact and then
> > rollback only that subxact?
>
> Well spotted, yes.
Latest version of same patch, but uses conflict reasons passed-thru
directly from recovery to backend.
Please review, no commit before tomorrow.
--
Simon Riggs www.2ndQuadrant.com
| Attachment | Content-Type | Size |
|---|---|---|
| hs_cancel.2010_Jan_14.patch | text/x-patch | 29.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matteo Beccati | 2010-01-14 12:23:31 | Re: mailing list archiver chewing patches |
| Previous Message | Heikki Linnakangas | 2010-01-14 12:14:44 | Re: Streaming replication and non-blocking I/O |