Skip site navigation (1) Skip section navigation (2)

Re: Hot Standby and query cancel

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org, Joachim Wieland <joe(at)mcknight(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Subject: Re: Hot Standby and query cancel
Date: 2010-01-13 19:20:29
Message-ID: 1263410429.26654.11980.camel@ebony (view raw or flat)
Thread:
Lists: pgsql-hackers
On Wed, 2010-01-13 at 19:58 +0100, Andres Freund wrote:

> > I am still testing patch, so should be confident to commit tomorrow
> > barring issues.
> I have only looked at briefly because right now I dont have the time (going to 
> eat at a friends place...) but I think I spotted an issue:
> The IsAbortedTransactionBlockState() check in RecoveryConflictInterrupt is not 
> correct right now because that returns true for TBLOCK_SUBABORT as well.
> Wouldnt that mess with the case where were in a failed subxact and then 
> rollback only that subxact?

Well spotted, yes. 

-- 
 Simon Riggs           www.2ndQuadrant.com

Attachment: hs_cancel.2010_Jan_13.v2.patch
Description: text/x-patch (22.2 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2010-01-13 19:21:32
Subject: Re: NEED HELP !
Previous:From: Robert HaasDate: 2010-01-13 19:15:09
Subject: Re: plpython3

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group