On Thu, 2010-01-07 at 15:29 -0500, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > On Thu, 2010-01-07 at 16:29 +0000, Tom Lane wrote:
> >> Fix (some of the) breakage introduced into query-cancel processing by HS.
> >> It is absolutely not okay to throw an ereport(ERROR) in any random place in
> >> the code just because DoingCommandRead is set; interrupting, say, OpenSSL
> >> in the midst of its activities is guaranteed to result in heartache.
> > ...That was not introduced by HS.
> Yes it was; or at least it was in your HS commit:
Ah, you were referring to those lines. I thought you were referring to
the additional lines you put in around ClientAuthInProgress.
Simon Riggs www.2ndQuadrant.com
In response to
pgsql-committers by date
|Next:||From: Tom Lane||Date: 2010-01-07 21:12:38|
|Subject: Re: pgsql: Fix (some of the) breakage introduced into query-cancel |
|Previous:||From: Robert Haas||Date: 2010-01-07 20:39:45|
|Subject: pgsql: Document why we copy reloptions into CacheMemoryContext |