Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Fix (some of the) breakage introduced into query-cancel

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix (some of the) breakage introduced into query-cancel
Date: 2010-01-07 20:46:49
Message-ID: 1262897209.19367.89795.camel@ebony (view raw or flat)
Thread:
Lists: pgsql-committers
On Thu, 2010-01-07 at 15:29 -0500, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > On Thu, 2010-01-07 at 16:29 +0000, Tom Lane wrote:
> >> Fix (some of the) breakage introduced into query-cancel processing by HS.
> 
> >> It is absolutely not okay to throw an ereport(ERROR) in any random place in
> >> the code just because DoingCommandRead is set; interrupting, say, OpenSSL
> >> in the midst of its activities is guaranteed to result in heartache.
> 
> > ...That was not introduced by HS.
> 
> Yes it was; or at least it was in your HS commit:
> 
> http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/postgres.c.diff?r1=1.578;r2=1.579

Ah, you were referring to those lines. I thought you were referring to
the additional lines you put in around ClientAuthInProgress.

-- 
 Simon Riggs           www.2ndQuadrant.com


In response to

Responses

pgsql-committers by date

Next:From: Tom LaneDate: 2010-01-07 21:12:38
Subject: Re: pgsql: Fix (some of the) breakage introduced into query-cancel
Previous:From: Robert HaasDate: 2010-01-07 20:39:45
Subject: pgsql: Document why we copy reloptions into CacheMemoryContext

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group