Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Fix (some of the) breakage introduced into query-cancel

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix (some of the) breakage introduced into query-cancel
Date: 2010-01-07 20:21:27
Message-ID: 1262895687.19367.89337.camel@ebony (view raw or flat)
Thread:
Lists: pgsql-committers
On Thu, 2010-01-07 at 16:29 +0000, Tom Lane wrote:

> Fix (some of the) breakage introduced into query-cancel processing by HS.

> It is absolutely not okay to throw an ereport(ERROR) in any random place in
> the code just because DoingCommandRead is set; interrupting, say, OpenSSL
> in the midst of its activities is guaranteed to result in heartache.

...That was not introduced by HS.

> Instead of that, undo the original optimizations that threw away
> QueryCancelPending anytime we were starting or finishing a command read, and
> instead discard the cancel request within ProcessInterrupts if we find that
> there is no HS reason for forcing a cancel and we are DoingCommandRead.
> 
> In passing, may I once again condemn the practice of changing the code
> and not fixing the adjacent comment that you just turned into a lie?

You may.

-- 
 Simon Riggs           www.2ndQuadrant.com


In response to

Responses

pgsql-committers by date

Next:From: Tom LaneDate: 2010-01-07 20:29:00
Subject: Re: pgsql: Fix (some of the) breakage introduced into query-cancel
Previous:From: Tom LaneDate: 2010-01-07 20:17:44
Subject: pgsql: Fix 3-parameter form of bit substring() to throw error for

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group