Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Add solaris path for docbook COLLATEINDEX

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Add solaris path for docbook COLLATEINDEX
Date: 2009-11-30 19:57:22
Message-ID: 1259611042.1115.130.camel@localhost (view raw or flat)
Thread:
Lists: pgsql-hackers
Peter Eisentraut píše v po 30. 11. 2009 v 21:27 +0200:
> On mån, 2009-11-30 at 19:53 +0100, Zdenek Kotala wrote:
> > Bruce Momjian píše v po 30. 11. 2009 v 12:32 -0500:
> > > I am not happy looking in a directory _above_ a specified directory by
> > > default:
> > > 
> > > 	             [$DOCBOOKSTYLE/bin $DOCBOOKSTYLE/.. $PATH])
> > > 
> > > That seems possibly unsafe.  I suggest you just add it to the PATH for
> > > Solaris builds.
> > 
> > I'm not sure if it is unsafer that searching in $PATH. Anyway I don't
> > think that your proposed solution is good way. I'm able to do it but how
> > many other people can? Who know where collateindex.pl stays on Solaris?
> > configure is here to make live easier for people. If we know how to do
> > it automatically we should do it.
> 
> Note that $DOCBOOKSTYLE/bin corresponds to the location of the file in
> an unpacked source archive and $PATH is of course where programs
> normally go.  The $DOCBOOKSTYLE/.. location makes no sense at all,
> because that basically says that the installer intentionally moved the
> file, but to a completely nonstandard location.

I'm not sgml//docbook guru. Do you think that Solaris location of
collateindex.pl is wrong? Does exist any recommendation for this? I
could log a bug, but I need some link with recommendation.

> > If you think that $DOCBOOKSTYLE/.. is not good than I propose to
> > use /usr/share/sgml/docbook/ directly.
> 
> That would be the less ugly solution.

Patch attached.

	thanks Zdenek

Attachment: docbook_02.patch
Description: text/x-patch (498 bytes)

In response to

Responses

pgsql-hackers by date

Next:From: Greg SmithDate: 2009-11-30 19:58:25
Subject: Re: cvs chapters in our docs
Previous:From: Kevin GrittnerDate: 2009-11-30 19:53:28
Subject: Re: Deleted WAL files held open by backends in Linux

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group