From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: new version of PQconnectdb was:(Re: [HACKERS] Determining client_encoding from client locale) |
Date: | 2009-11-03 11:31:14 |
Message-ID: | 1257247874.25627.2.camel@fsopti579.F-Secure.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, 2009-09-27 at 21:49 -0400, Robert Haas wrote:
> On Wed, Sep 23, 2009 at 3:26 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec> writes:
> >> i extracted the functions to connect that Heikki put on psql in his
> >> patch for determining client_encoding from client locale and put it in
> >> libpq so i follow the PQconnectdbParams(* params[]) approach.
> >
> > I got around to looking at the actual patch a bit. I hadn't understood
> > why it was so small, but now I do: it's implemented as a wrapper around
> > PQconnectdb. That is, it takes the given keywords and values, and
> > builds a conninfo string, which PQconnectdb then has to pull apart
> > again.
> Based on this review, it sounds like this patch will need a major
> rewrite before it can be seriously reviewed. Given that, I think it
> makes sense to postpone this to the next CommitFest, so I am going to
> mark it as Returned with Feedback.
Is anyone planning to do further work on this? This appears to be
blocking the client_encoding=auto feature.
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2009-11-03 12:44:57 | Re: per-tablespace random_page_cost/seq_page_cost |
Previous Message | Alvaro Herrera | 2009-11-03 11:25:46 | Re: per-tablespace random_page_cost/seq_page_cost |