Re: \d+ for long view definitions?

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: \d+ for long view definitions?
Date: 2009-10-29 22:41:26
Message-ID: 1256856086.9673.2.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On tis, 2009-09-01 at 14:29 -0400, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > I think we should always or never show the view definition, not sometimes.
>
> Yeah. I can live with \d not showing it and \d+ showing it --- as Peter
> already mentioned, that would be consistent with \df behavior. Making
> it depend on the length is just weird.

The patch for this endeavor is:

diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
--- a/src/bin/psql/describe.c
+++ b/src/bin/psql/describe.c
@@ -1306,7 +1306,7 @@ describeOneTableDetails(const char *schemaname,
printTableAddHeader(&cont, headers[i], true, 'l');

/* Check if table is a view */
- if (tableinfo.relkind == 'v')
+ if (tableinfo.relkind == 'v' && verbose)
{
PGresult *result;

Any final words?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2009-10-29 23:24:22 grant with hierarchy option
Previous Message Jeff Davis 2009-10-29 22:19:42 Re: Syntax for partitioning