| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Hot Standby on git |
| Date: | 2009-10-01 14:45:30 |
| Message-ID: | 1254408330.17864.233.camel@ebony.2ndQuadrant |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2009-09-30 at 09:33 +0300, Heikki Linnakangas wrote:
> Looking at the changes to StartupMultiXact, you're changing the locking
> so that both MultiXactOffsetControlLock and MultiXactMemberControlLock
> are acquire first before changing anything. Why? Looking at the other
> functions in that file, all others that access both files are happy to
> acquire one lock at a time, like StartupMultiXact does without the patch.
I think those changes are just paranoia from early versions of patch.
We now know for certain that MultiXact isn't used at the time
StartupMultiXact() is called. The same isn't true for StartupClog() and
StartupSubtrans() which need to cope with concurrent callers.
Will remove changes and document that nothing touching it when it runs.
--
Simon Riggs www.2ndQuadrant.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2009-10-01 14:48:57 | Re: navigation menu for documents |
| Previous Message | Simon Riggs | 2009-10-01 14:39:27 | Re: Hot Standby on git |