Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] Patch to add version numbers to libpq.rc

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Magnus Hagander <mha(at)sollentuna(dot)net>,PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>,Dave Page <dpage(at)vale-housing(dot)co(dot)uk>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] Patch to add version numbers to libpq.rc
Date: 2004-12-17 00:42:11
Message-ID: 12538.1103244131@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>>> One difficulty was generating a new version of libpq.rc at the proper
>>> time.  I added a prepdist rule just like *.def.  I also added code so
>>> every time you do a 'make clean' or distclean it does a 'touch' on
>>> libpq.rc.in so libpq.rc is rebuilt on the next compile.  That seemed
>>> like the cleanest solution.
>> 
>> ... except CVS will not like it at all.  Why don't you just remove the
>> libpq.rc file instead?

> I am going to remove libpq.rc from CVS because it is now a derived file
> from libpq.rc.in.  I don't remove via 'clean' because if someone wants
> to build VC or BCC and Win32 with the same tarball then once they do a
> 'clean' they can't do a VC or BCC compile anymore.

> Does that answer your question?

Not in the least.

What I'm complaining about is that you can't simply "touch" a file that
is under CVS control; CVS will think it's been modified.

Perhaps it would work to make libpq.rc depend on both libpq.rc.in and
src/Makefile.global; then any re-configure would force it to be rebuilt.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-12-17 01:14:42
Subject: Re: [PATCHES] Patch to add version numbers to
Previous:From: Bruce MomjianDate: 2004-12-17 00:37:37
Subject: Re: [PATCHES] Patch to add version numbers to

pgsql-hackers-win32 by date

Next:From: Bruce MomjianDate: 2004-12-17 01:14:42
Subject: Re: [PATCHES] Patch to add version numbers to
Previous:From: Bruce MomjianDate: 2004-12-17 00:37:37
Subject: Re: [PATCHES] Patch to add version numbers to

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group