Re: [PATCH] plpythonu datatype conversion improvements

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Caleb Welton <cwelton(at)greenplum(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] plpythonu datatype conversion improvements
Date: 2009-08-31 20:41:45
Message-ID: 1251751305.20938.10.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On sön, 2009-08-16 at 02:44 +0300, Peter Eisentraut wrote:
> The remaining problem is that the patch loses domain checking on the
> return types, because some paths no longer go through the data type's
> input function. I have marked these places as FIXME, and the regression
> tests also contain a failing test case for this.
>
> What's needed here, I think, is an API that takes a datum plus type
> information and checks whether the datum is valid within the domain. I
> haven't found one that is exported, but maybe someone could give a tip.

Got that fixed now. Updated patch is attached. I will sleep over it,
but I think it's good to go.

Attachment Content-Type Size
plpython-datatypes.patch text/x-patch 28.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2009-08-31 21:00:20 Re: [PATCH] Largeobject access controls
Previous Message Bruce Momjian 2009-08-31 20:40:17 Re: 8.5 release notes idea