Skip site navigation (1) Skip section navigation (2)

Re: Logging configuration changes

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Logging configuration changes
Date: 2009-08-28 21:38:07
Message-ID: 1251495487.18151.12.camel@vanquo.pezone.net (view raw or flat)
Thread:
Lists: pgsql-hackers
On ons, 2009-08-26 at 22:13 -0400, Tom Lane wrote:
> Seems to me it would be too chatty to be useful, at least for people who
> set more than one or two things in postgresql.conf.  Would it be that
> hard to track which values actually changed?  Without having looked at
> the code, I'm thinking that much of the infrastructure must be there
> already now that we have support for undoing commented-out settings.

Found an easy solution; see attached patch.

On a related note, I suggest reverting or revising this logging change:
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=293c816e4aad8e760bcb4eaba0aa16da0ccd2d04
Putting the reason for an error or warning into the detail part is not
acceptable style, IMO.

Attachment: log-parameter-changes.diff
Description: text/x-patch (1.4 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Kevin GrittnerDate: 2009-08-28 21:41:47
Subject: Re: Linux LSB init script
Previous:From: Peter EisentrautDate: 2009-08-28 21:34:17
Subject: Re: Add YAML option to explain

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group