Skip site navigation (1) Skip section navigation (2)

Re: Thanks.

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-rrreviewers(at)postgresql(dot)org
Subject: Re: Thanks.
Date: 2009-08-10 03:43:32
Message-ID: 1249875812.9256.1696.camel@jdavis (view raw or flat)
Thread:
Lists: pgsql-rrreviewers
On Sun, 2009-08-09 at 22:06 -0400, Robert Haas wrote:
> Comments?  Thoughts on how to do it better next time?  Want to
> volunteer to do something?  Hit that reply button.

I think we might want an additional returned status, like "Returned
Pending Discussion" to indicate that we, as a community, don't know
whether the patch is right or not.

For instance the "Parser's hook based on FuncCall" patch. I don't
necessarily feel like the author was given enough feedback to really
complete the patch, nor was it outright rejected.

There's no obvious solution, but maybe we should aim for some breathing
room in between commitfests so that the necessary discussion can happen.
I'm a little worried that with only a month, people will mostly be
working on their own features and waiting until the next commitfest to
really have any discussions.

This is somewhat selfish, because with the commitfest over, I'll be
trying to get my "Generalized Index Constraints" patch into shape. I'd
like to get feedback on a few specific things before I try to make a
commit-able version of the patch (with docs, psql/pg_dump support,
etc.).

Let me say that I also think the commitfest has been a tremendously
successful and efficient process. We got a lot of great submissions very
early in the 8.5 cycle, which will hopefully ease the schedule near
release time. So I might be worried about nothing at all.

Regards,
	Jeff Davis



In response to

  • Thanks. at 2009-08-10 02:06:04 from Robert Haas

pgsql-rrreviewers by date

Next:From: Josh BerkusDate: 2009-08-10 19:09:01
Subject: Re: Thanks.
Previous:From: Robert HaasDate: 2009-08-10 02:06:04
Subject: Thanks.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group