Re: Change: l10n patch

Dave Page píše v Po 03. 08. 2009 v 12:26 +0100:
> On Mon, Aug 3, 2009 at 12:10 PM, Guillaume
> Lelarge<guillaume(at)lelarge(dot)info> wrote:
>
> > I tried this too, and it works AFAICT.
> >
> > Not sure why, in some place we use the _ and in other places, we use
> > wxGetTranslation.

wxGetTranslation isn't passed by argument -k to xgettext in
stringextract script.

Macro _(s) do automatic cast with macro _T(s) before call
wxGetTranslation.

So _(s) is useful for constant strings, which should be extracted to
POT. And wxGetTranslation is useful for wxString variables (expressions
are extracted elsewher, e.g by N_(s) in structure).

>
> iirc, there is a reason, but I'm darned if I can remember what it it.
> Of course, wxGetTranslation won't work well with the stringextract
> scripts.
>
> > Apart from that, the code Marek wrote is looking good. I'll work on the
> > ordering in some time. Or perhaps Marek can work on this, if he agrees. I
> > don't know enough right know to have a good answer for you. Anyways, there are
> > other codes in pgadmin that looks like what Marek wrote, so I think we would
> > better apply his patch, and work on the ordering in a separate patch.
>
> OK - I'll leave this stuff in your capable hands then :-)
>
> Thanks!
>
> --
> Dave Page
> EnterpriseDB UK: http://www.enterprisedb.com
>