Greg Stark <stark(at)mit(dot)edu> writes:
> So I'm thinking of something like this.
> Ignore ESDIR when opening a directory (and return immediately)
> and ignore EBADF when trying to fsync a directory.
Seems reasonable, but get rid of the comment "However we can't do this
just yet, it has portability issues"; and you've got a double semicolon
in one place. It might also be worth commenting the BasicOpenFile calls
along the lines of "Many OSs don't let us open directories RDWR, while
some reject fsync on files opened RDONLY, so we need two cases."
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Josh Berkus||Date: 2010-02-28 19:47:38|
|Subject: Re: Re: Hot Standby query cancellation and Streaming Replication
|Previous:||From: Tom Lane||Date: 2010-02-28 19:25:57|
|Subject: Simple fix for contrib/xml2|
pgsql-committers by date
|Next:||From: Tom Lane||Date: 2010-02-28 19:51:37|
|Subject: pgsql: Assorted code cleanup for contrib/xml2.|
|Previous:||From: Greg Stark||Date: 2010-02-28 18:00:07|
|Subject: Re: [COMMITTERS] Re: pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after|