| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] GIN improvements |
| Date: | 2009-01-21 18:07:51 |
| Message-ID: | 1232561271.23793.46.camel@jdavis |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Wed, 2009-01-21 at 15:06 +0300, Teodor Sigaev wrote:
> Done. Now GIN counts number of pending tuples and pages and stores they on
> metapage. Index cleanup could start during normal insertion in two cases:
> - number of pending tuples is too high to keep guaranteed non-lossy tidbitmap
> - pending page's content doesn't fit into work_mem.
Great, thanks. I will take a look at this version tonight.
Because time is short, I will mark it as "Ready for committer review"
now. I think all of the major issues have been addressed, and I'll just
be looking at the code and testing it.
> BTW, gincostestimate could use that information for cost estimation, but is
> index opening and metapge reading in amcostestimate acceptable?
That sounds reasonable to me. I think that's what the index-specific
cost estimators are for. Do you expect a performance impact?
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Carlos Gonzalez-Cadenas | 2009-01-21 18:09:28 | deductive databases in postgreSQL |
| Previous Message | Robert Haas | 2009-01-21 18:02:21 | Re: [PATCH] EnableDisableTrigger Cleanup & Questions |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2009-01-22 12:21:48 | Re: [PATCHES] GIN improvements |
| Previous Message | Teodor Sigaev | 2009-01-21 12:06:44 | Re: [PATCHES] GIN improvements |