Re: [PATCHES] GIN improvements

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] GIN improvements
Date: 2009-01-20 18:01:29
Message-ID: 1232474489.23316.8.camel@jdavis
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Mon, 2009-01-19 at 19:53 +0300, Teodor Sigaev wrote:
> I see only two guaranteed solution of the problem:
> - after limit is reached, force normal index inserts. One of the motivation of
> patch was frequent question from users: why update of whole table with GIN index
> is so slow? So this way will not resolve this question.
> - after limit is reached, force cleanup of pending list by calling
> gininsertcleanup. Not very good, because users sometimes will see a huge
> execution time of simple insert. Although users who runs a huge update should be
> satisfied.
>
> I have difficulties in a choice of way. Seems to me, the better will be second
> way: if user gets very long time of insertion then (auto)vacuum of his
> installation should tweaked.
>

I agree that the second solution sounds better to me.

With the new Visibility Map, it's more reasonable to run VACUUM more
often, so those that are inserting single tuples at a time should not
encounter the long insert time.

I'm still looking at the rest of the patch.

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hiroshi Inoue 2009-01-20 18:06:00 Re: [BUGS] BUG #4186: set lc_messages does not work
Previous Message Tom Lane 2009-01-20 17:59:46 Re: Column-Level Privileges

Browse pgsql-patches by date

  From Date Subject
Next Message Bryce Nesbitt 2009-01-20 21:04:07 New pg_dump patch, --no-stats flag, disables sending to statistics collector
Previous Message Teodor Sigaev 2009-01-19 18:15:57 Re: [PATCHES] GIN improvements