Skip site navigation (1) Skip section navigation (2)

Re: erroneous restore into pg_catalog schema

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Erik Rijkers" <er(at)xs4all(dot)nl>
Cc: "Dimitri Fontaine" <dimitri(at)2ndquadrant(dot)fr>, pgsql-hackers(at)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
Subject: Re: erroneous restore into pg_catalog schema
Date: 2013-01-13 21:37:53
Message-ID: 12317.1358113073@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
"Erik Rijkers" <er(at)xs4all(dot)nl> writes:
> On Sun, January 13, 2013 22:09, Tom Lane wrote:
>> BTW, although Erik claimed this behaved more sanely in 9.2, a closer
>> look at the commit logs says that the bogus commit shipped in 9.2,
>> so AFAICS it's broken there too.

> [ not so ]

Hm, you are right, there's another problem that's independent of
search_path.  In 9.2,

regression=# create table pg_catalog.t(f1 int);
ERROR:  permission denied to create "pg_catalog.t"
DETAIL:  System catalog modifications are currently disallowed.

but HEAD is missing that error check:

regression=# create table pg_catalog.t(f1 int);
CREATE TABLE

I will bet that this is more breakage from the DDL-code refactoring that
has been going on.  I am getting closer and closer to wanting that
reverted.  KaiGai-san seems to have been throwing out lots of special
cases that were there for good reasons.

			regards, tom lane


In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2013-01-13 21:43:28
Subject: Re: count(*) of zero rows returns 1
Previous:From: Andres FreundDate: 2013-01-13 21:31:45
Subject: Re: erroneous restore into pg_catalog schema

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group