Skip site navigation (1) Skip section navigation (2)

Re: Review: B-Tree emulation for GIN

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review: B-Tree emulation for GIN
Date: 2008-12-29 07:41:14
Message-ID: 1230536474.4835.85.camel@jdavis (view raw or flat)
Thread:
Lists: pgsql-hackers
On Fri, 2008-12-19 at 13:26 +0300, Teodor Sigaev wrote:
> Updated patch.

I have merged this with HEAD, written a brief document (which is mostly
a copy of the btree-gist page), added the module to the contrib
Makefile, and made some very minor changes. Patch attached.

A couple comments:

1. Right now, to implement "less than" you need to start at the
beginning of the index and scan until you reach the supplied query
datum. This is because GIN doesn't support backwards scans
( http://archives.postgresql.org/pgsql-hackers/2008-07/msg01146.php ).

Unfortunately, that means numeric is not supportable for btree-gin
because there is no left-most value from which to start the scan. Do you
see an easy workaround to support numeric?

2. Why do you create a shell type "int32" from btree_gin.sql? I tried
doing a search-and-replace to use "int4" instead, and it seems to work
fine (and eliminates the warnings). I left it with int32 in my version
of the patch because I thought you may have some reason for using it.

Regards,
	Jeff Davis

Attachment: btree-gin.20081228.patch.gz
Description: application/x-gzip (13.9 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2008-12-29 09:08:23
Subject: Re: pg_start_backup without checkpoint patch (a part of Synch Rep)
Previous:From: Hitoshi HaradaDate: 2008-12-29 07:08:28
Subject: Re: TODO items for window functions

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group