Re: Immediate shutdown during recovery

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Immediate shutdown during recovery
Date: 2008-11-28 15:40:13
Message-ID: 1227886813.20796.162.camel@hp_dx2400_1
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Fri, 2008-11-28 at 19:53 +0900, Fujii Masao wrote:
> Hi,
>
> On Fri, Nov 28, 2008 at 6:56 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> > Hi,
> >
> > The immediate shutdown (pg_ctl -m i stop) might not be able to
> > kill the startup process during archive recovery. It's because
> > the startup process calls system() which ignores SIGQUIT for
> > executing the restore_command. So, only the startup process
> > might survive the immediate shutdown and continue redoing up
> > to the end. Is this desirable behavior? This sounds odd for me.
>
> In RestoreArchivedFile(), there is the following code as the safeguard
> against the termination of restore_command by signal. But the
> safeguard might not work if restore_command defines its own signal
> handler for SIGQUIT like pg_standby.
>
> > signaled = WIFSIGNALED(rc) || WEXITSTATUS(rc) > 125;
> >
> > ereport(signaled ? FATAL : DEBUG2,
> > (errmsg("could not restore file \"%s\" from archive: return code %d",
> > xlogfname, rc)));

Agree there is an existing problem.

Suggest we fix it after the main patches are committed.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2008-11-28 15:58:43 Re: Distinct types
Previous Message Magnus Hagander 2008-11-28 15:13:54 Re: Re: [COMMITTERS] pgsql: Add support for matching wildcard server certificates to the new