| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review: Hot standby |
| Date: | 2008-11-25 19:13:07 |
| Message-ID: | 1227640387.14213.12.camel@hp_dx2400_1 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2008-11-25 at 19:02 +0530, Pavan Deolasee wrote:
> On Tue, Nov 25, 2008 at 6:55 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Huh? The "read only" transaction mode is not hard read-only
> anyway,
> so if that's the only step being taken, it's entirely useless.
>
>
> I think there are explicit checks for some utility statements (like
> VACUUM), but I haven't checked if all necessary code paths are covered
> or not.
The commands that need protecting have been explicitly identified in the
notes and there are 7 files changed that were specifically identified
with protective changes.
You've identified a way of breaking part the first line of defence, but
the command was caught by the second line of defence in the patch.
Problem, yes. Major issue, no. Will fix.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2008-11-25 19:14:10 | Re: [bugfix] DISCARD ALL does not release advisory locks |
| Previous Message | Heikki Linnakangas | 2008-11-25 18:12:50 | Re: Comments to Synchronous replication patch v3 |