Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Infrastructure changes for recovery

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Infrastructure changes for recovery
Date: 2008-09-12 18:56:06
Message-ID: 1221245766.3913.1130.camel@ebony.2ndQuadrant (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Fri, 2008-09-12 at 14:14 -0400, Alvaro Herrera wrote:
> Simon Riggs wrote:
> 
> > --- 5716,5725 ----
> >   						CheckpointStats.ckpt_sync_end_t,
> >   						&sync_secs, &sync_usecs);
> >   
> > ! 	elog(LOG, "%s complete: wrote %d buffers (%.1f%%); "
> >   		 "%d transaction log file(s) added, %d removed, %d recycled; "
> >   		 "write=%ld.%03d s, sync=%ld.%03d s, total=%ld.%03d s",
> > + 		 (checkpoint ? "  checkpoint" : "restartpoint"),
> >   		 CheckpointStats.ckpt_bufs_written,
> >   		 (double) CheckpointStats.ckpt_bufs_written * 100 / NBuffers,
> >   		 CheckpointStats.ckpt_segs_added,
> 
> Very minor nit: this really needs a rework.  

All I changed was the word "restartpoint"... its otherwise identical to
existing message. I'd rather not change that.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support


In response to

Responses

pgsql-hackers by date

Next:From: Ron MayerDate: 2008-09-12 19:09:35
Subject: Re: Proposed patch: make SQL interval-literal syntax work per spec
Previous:From: David E. WheelerDate: 2008-09-12 18:49:04
Subject: Re: [Review] Tests citext casts by David Wheeler.

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2008-09-12 19:31:44
Subject: Re: [HACKERS] Infrastructure changes for recovery
Previous:From: Alvaro HerreraDate: 2008-09-12 18:14:21
Subject: Re: [HACKERS] Infrastructure changes for recovery

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group