Skip site navigation (1) Skip section navigation (2)

Re: [pgsql-hackers-win32] snprintf causes regression tests to fail

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Nicolai Tufar <ntufar(at)gmail(dot)com>,Magnus Hagander <mha(at)sollentuna(dot)net>,PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>,PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgreSQL(dot)org>
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests to fail
Date: 2005-03-02 18:21:47
Message-ID: 12196.1109787707@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32pgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> First line of thought: we surely must not insert a snprintf into
>> libpq.so unless it is 100% up to spec *and* has no performance issues
>> ... neither of which can be claimed of the CVS-tip version.

> Agreed, and we have to support all the 64-bit specifications a port
> might support like %qd and %I64d as well as %lld.  I have added that to
> our current CVS version.

I really dislike that idea and request that you revert it.

> Is there any way we can have just gettext() call our snprintf under a
> special name?

The issue only comes up in libpq --- in the backend there is no reason
that snprintf can't be our snprintf, and likewise in self-contained
programs like psql.  It might be worth the pain-in-the-neck quality to
have libpq refer to the functions as pq_snprintf etc.  Perhaps we could
do this via macros

#define snprintf	pq_snprintf

and not have to uglify the source code.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: WesDate: 2005-03-02 18:36:01
Subject: Re: Vacuum time degrading
Previous:From: WesDate: 2005-03-02 18:21:44
Subject: Re: Vacuum time degrading

pgsql-patches by date

Next:From: David FetterDate: 2005-03-02 18:29:01
Subject: Re: [BUGS] typos in the docu
Previous:From: Bruce MomjianDate: 2005-03-02 18:16:27
Subject: Re: [pgsql-hackers-win32] [HACKERS] snprintf causes regression

pgsql-hackers-win32 by date

Next:From: Ken EgervariDate: 2005-03-02 18:28:43
Subject: Re: Help with tuning this query
Previous:From: Ragnar HafstaĆ°Date: 2005-03-02 18:13:47
Subject: Re: Help with tuning this query

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group