From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc:
Nicolai Tufar <ntufar(at)gmail(dot)com>,Magnus Hagander <mha(at)sollentuna(dot)net>,PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>,PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgreSQL(dot)org>
Subject:
Re: [pgsql-hackers-win32] snprintf causes regression tests to fail
Date:
2005-03-02 18:21:47
Message-ID:
12196.1109787707@sss.pgh.pa.us (view raw or flat )
Thread:
2005-03-02 01:55:11 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 02:32:39 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-02 02:38:55 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 03:23:18 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 04:21:24 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-02 04:23:08 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 04:31:19 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 05:22:14 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 05:38:59 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-02 06:06:35 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-02 06:33:05 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-02 15:41:00 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 16:00:53 from pgsql(at)mohawksoft(dot)com
2005-03-02 18:21:47 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-02 21:38:28 from pgsql(at)mohawksoft(dot)com
2005-03-03 00:03:02 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-09 12:40:24 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-09 15:38:27 from pgsql(at)mohawksoft(dot)com
2005-03-10 03:51:27 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-10 19:22:13 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-10 21:26:47 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-10 22:43:48 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-11 16:21:23 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-10 23:55:06 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-11 00:21:41 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-11 01:29:49 from pgsql(at)mohawksoft(dot)com
2005-03-11 03:58:27 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-11 16:18:07 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-11 17:02:29 from pgsql(at)mohawksoft(dot)com
2005-03-11 17:14:26 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-11 17:23:36 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-11 17:37:24 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-11 17:44:19 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-11 04:10:12 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-11 05:58:11 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-11 06:14:31 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-11 06:41:39 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-11 23:58:15 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-12 15:00:14 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-16 06:00:21 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-16 11:36:50 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-16 15:07:28 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-16 21:28:07 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-20 05:11:18 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-20 06:49:37 from Greg Stark <gsstark(at)mit(dot)edu>
2005-03-20 18:23:58 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2005-05-05 21:03:11 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-14 18:55:16 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-14 19:19:14 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-14 19:39:19 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-14 19:41:01 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-10 21:19:33 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 12:09:37 from pgsql(at)mohawksoft(dot)com
Lists:
pgsql-hackers pgsql-hackers-win32 pgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> First line of thought: we surely must not insert a snprintf into
>> libpq.so unless it is 100% up to spec *and* has no performance issues
>> ... neither of which can be claimed of the CVS-tip version.
> Agreed, and we have to support all the 64-bit specifications a port
> might support like %qd and %I64d as well as %lld. I have added that to
> our current CVS version.
I really dislike that idea and request that you revert it.
> Is there any way we can have just gettext() call our snprintf under a
> special name?
The issue only comes up in libpq --- in the backend there is no reason
that snprintf can't be our snprintf, and likewise in self-contained
programs like psql. It might be worth the pain-in-the-neck quality to
have libpq refer to the functions as pq_snprintf etc. Perhaps we could
do this via macros
#define snprintf pq_snprintf
and not have to uglify the source code.
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: WesDate: 2005-03-02 18:36:01Subject : Re: Vacuum time degrading Previous :From : WesDate : 2005-03-02 18:21:44Subject : Re: Vacuum time degrading
pgsql-patches by date
Next :From: David FetterDate: 2005-03-02 18:29:01Subject : Re: [BUGS] typos in the docuPrevious :From : Bruce MomjianDate : 2005-03-02 18:16:27Subject : Re: [pgsql-hackers-win32] [HACKERS] snprintf causes regression
pgsql-hackers-win32 by date
Next :From: Ken EgervariDate: 2005-03-02 18:28:43Subject : Re: Help with tuning this queryPrevious :From : Ragnar HafstaðDate : 2005-03-02 18:13:47Subject : Re: Help with tuning this query
