Skip site navigation (1) Skip section navigation (2)

Re: pg_dump additional options for performance

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, daveg <daveg(at)sonic(dot)net>, pgsql-patches(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pg_dump additional options for performance
Date: 2008-07-23 17:09:47
Message-ID: 1216832987.3894.678.camel@ebony.2ndQuadrant (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Wed, 2008-07-23 at 17:40 +0100, Simon Riggs wrote:
> On Mon, 2008-07-21 at 07:56 -0400, Stephen Frost wrote:
> > Simon,
> > 
> > * Simon Riggs (simon(at)2ndquadrant(dot)com) wrote:
> > > > I hadn't realized that Simon was using "pre-schema" and "post-schema"
> > > > to name the first and third parts.  I'd agree that this is confusing
> > > > nomenclature: it looks like it's trying to say that the data is the
> > > > schema, and the schema is not!  How about "pre-data and "post-data"?
> > > 
> > > OK by me. Any other takers?
> > 
> > Having the command-line options be "--schema-pre-data" and
> > "--schema-post-data" is fine with me.  Leaving them the way they are is
> > also fine by me.  It's the documentation (back to pg_dump.sgml,
> > ~774/~797) that starts talking about Pre-Schema and Post-Schema.
> 
> OK, Mr.Reviewer, sir:
> 
> * patch redone using --schema-before-data and --schema-after-data
> 
> * docs rewritten using short clear descriptions using only the words
> "before" and "after", like in the option names
> 
> * all variable names changed
> 
> * retested
> 
> So prefixes "pre" and "post" no longer appear anywhere. No latin derived
> phrases, just good ol' Anglo-Saxon words.

...and with command line help also.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support

Attachment: pg_dump_beforeafter.v5.patch
Description: text/x-patch (37.9 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Matthew T. O'ConnorDate: 2008-07-23 17:33:35
Subject: Re: Do we really want to migrate plproxy and citext into PG core distribution?
Previous:From: Peter EisentrautDate: 2008-07-23 17:08:53
Subject: Re: pltcl_*mod commands are broken on Solaris 10

pgsql-patches by date

Next:From: Heikki LinnakangasDate: 2008-07-23 18:38:56
Subject: Re: [PATCHES] odd output in restore mode
Previous:From: Simon RiggsDate: 2008-07-23 16:40:37
Subject: Re: pg_dump additional options for performance

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group