Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] odd output in restore mode

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Dave Page <dpage(at)pgadmin(dot)org>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] odd output in restore mode
Date: 2008-07-01 08:39:08
Message-ID: 1214901548.3845.544.camel@ebony.site (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Mon, 2008-06-30 at 19:29 -0400, Andrew Dunstan wrote:
> 
> Bruce Momjian wrote:
> > Dave Page wrote:
> >   
> >> On Sun, May 18, 2008 at 1:38 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> >>     
> >>> I don't know how you tested,
> >>>       
> >> Copy a large file across a relatively slow network, and check the size
> >> on the destination drive before it finishes.
> >>
> >>     
> >>> but could you please repeat the test with
> >>> GnuWin32's cp.exe? If it doesn't preallocate the space then I think our way
> >>> forward is reasonably clear:
> >>>       
> >> It does not pre-allocate.
> >>
> >>     
> >>> . we recommend its use for Windows archive_command settings
> >>> . we provide the delay kluge as switchable behaviour on Windows instead of
> >>> having it always on.
> >>>       
> >> Sounds reasonable to me.
> >>     
> >
> > Are there any changes we need to make here?
> >
> >   
> 
> Yes. Simon has promised a patch to do the above.

Patch implements

* recommendation to use GnuWin32 cp on Windows
* provide "holdtime" delay, default 0 (on all platforms)
* default stays same on Windows="copy" to ensure people upgrading don't
get stung

Patch should be backpatched to 8.3, plus to CVS HEAD.

We should recommend in next 8.3 release notes that people use "-p" or
"-l" rather than just letting it default.

Will add permalink to Wiki when patch appears in archives.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support

Attachment: pg_standby_win32.v1.patch
Description: text/x-patch (9.7 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Gregory StarkDate: 2008-07-01 09:11:09
Subject: Re: Planned obsolescence in identify_system_timezone()
Previous:From: Richard HuxtonDate: 2008-07-01 07:45:44
Subject: Re: Does anything dump per-database config settings? (was Re: ALTER DATABASE vs pg_dump)

pgsql-patches by date

Next:From: Heikki LinnakangasDate: 2008-07-01 10:33:24
Subject: Re: extend VacAttrStats to allow stavalues of different types
Previous:From: Simon RiggsDate: 2008-07-01 07:41:34
Subject: Re: VACUUM Improvements - WIP Patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group